This is a migrated thread and some comments may be shown as answers.

Function calls from Templates

11 Answers 340 Views

MVVM

This is a migrated thread and some comments may be shown as answers.

11 Answers, 1 is accepted

answered on 20 Apr 2012, 02:52 AM

I'm kind of shooting in the dark here, but the problem seems to be that if I have a DataSource within an ObservaleObject, then its "parent()" function will return undefined.

On the other hand, if I have a javascript array within an ObservableObject, then calling parent() on it will indeed return the ObservableObject.

This seems to be crucial because of this bit of code in kendo:

var EventBinding = Binding.extend( {

get: function() {

var source = this.source,

path = this.path,

handler;

handler = source.get(path);

while (!handler && source) {

source = source.parent();

if (source instanceof ObservableObject) {

handler = source.get(path);

}

return proxy(handler, source);

}

});

on the line:

source = source.parent();

we "walk up" the hierarchy to find an appropriate function for the event binding. In the case of a regular array item, we will eventually find the ObservableObject, but in the case of a DataSource the ObservableObject is never found.

I hope this helps solve this issue.

Regards

answered on 20 Apr 2012, 05:39 AM

kendo-all.zip

More on this,

I have tracked down the source of the problem (or at least I think I did).

Here's a diff of what I changed:

--- C:/Users/luc/Documents/KendoUI/source/js/kendo.all.js Fri Apr 06 18:00:56 2012

+++ C:/Users/luc/Documents/Visual Studio 11/Projects/WebApi1/WebApi1/Scripts/kendo.all.js Fri Apr 20 00:17:17 2012

@@ -4195,6 +4195,8 @@

that.trigger(CHANGE, { field: field, index: e.index, items: e.items, action: e.action});

});

})(field);

+ } else if (object instanceof DataSource) {

+ object.parent = parent;

}

return object;

@@ -5652,7 +5654,10 @@

_observe: function(data) {

var that = this,

model = that.reader.model,

- wrap = false;

+ wrap = false,

+ parent = function () {

+ return that;

+ };

if (model && data.length) {

wrap = !(data[0] instanceof model);

@@ -5665,6 +5670,7 @@

}

} else {

data = new ObservableArray(data, that.reader.model);

+ data.parent = parent;

}

return data.bind(CHANGE, proxy(that._change, that));

Basically, when wrapping the return from the DataSource.read() in _observe(), we need to also assign the parent of the newly created ObservableArray.

Also, in ObservableObject.wrap(), we need to take into account the case where we are wrapping a DataSource object and also assign its parent.

Please review this patch and let me know if it induces unwanted side-effect. I've been working on this for almost 6 hours straight, and I'm not sure I'm still seeing straight enough.

Regards

Product Bundles

DevCraft

Web

Mobile

Document Management

Desktop

Reporting & Mocking

Automated Testing

CMS

UI/UX Tools

Debugging

Free Tools

Support and Learning

Productivity and Design Tools

Function calls from Templates

11 Answers, 1 is accepted